[CSApply] NFC: Clean up some duplicated logic for propagating async from contextual types to closure types.
#37282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`async` from contextual types to closure types. This preserves the behavior that `async` is propagated to closures that should inherit the surrounding actor context, even if the closure is an argument to a reasync function.
|
@swift-ci please smoke test |
xedin
approved these changes
May 6, 2021
| if (auto *call = getAsExpr<ApplyExpr>(locator.getAnchor())) { | ||
| if (auto *declRef = dyn_cast<DeclRefExpr>(call->getFn())) { | ||
| if (auto *fn = dyn_cast<AbstractFunctionDecl>(declRef->getDecl())) | ||
| return !fn->hasPolymorphicEffect(kind); | ||
| return fn->hasPolymorphicEffect(kind); |
There was a problem hiding this comment.
IHMO naming of this method could be improved it's clear what polymorphism has to do with this and there is no comment at the declaration site. @hborla told me that this is about interaction between reasync/rethrows and async/throws attributes.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #37263, where I accidentally duplicated some code in
coerceToType. The new code is clearer about whenasyncis propagated to closure types, which is when the effect is not polymorphic or when the closure inherits the surrounding actor context.Note that this change preserves the behavior that
asyncis propagated to closures that inherit the surrounding actor context, even if the closure is an argument to areasyncfunction. I'm not actually sure how@_inheritActorContextandreasyncare supposed to interact.