Fix an assert in exclusivity diagnostics when inouts escape. #37285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error found in DiagnoseInvalidEscapingCaptures can indicate invalid SIL, which will cause DiagnoseStaticExclusivity to assert during SIL verification. When the source-level closure captures an inout argument, it appears in SIL to be a non-escaping closure. The SIL verification then fails because the "nonescaping" closure actually escapes. Ensure that capture diagnostics run on closures before exclusivity enforcement runs on the parent function. Bypass the SIL verification assert if a diagnostic error was found. Fixes rdar://75364904 (Crash with assertion `noescape partial_apply has unexpected use`)
|
@swift-ci test |
|
Build failed |
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
|
1st spurious error: playgrounds |
|
3rd spurious error: Driver/Dependencies/only-skip-once.swift |
|
@swift-ci smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error found in DiagnoseInvalidEscapingCaptures can indicate invalid
SIL, which will cause DiagnoseStaticExclusivity to assert during SIL
verification. When the source-level closure captures an inout
argument, it appears in SIL to be a non-escaping closure. The SIL
verification then fails because the "nonescaping" closure actually
escapes.
Ensure that capture diagnostics run on closures before exclusivity
enforcement runs on the parent function. Bypass the SIL verification
assert if a diagnostic error was found.
Fixes rdar://75364904 (Crash with assertion
noescape partial_apply has unexpected use)