[5.5][Diagnostics] Handle ambiguities related to use of nil literal
#37291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… its argument node (cherry picked from commit 2f44f5b)
…rgument position New note mentions both expected argument type and its position and anchors to the affected overload choice. (cherry picked from commit af3dcf0)
When `nil` is passed as an argument to call with multiple overloads it's possible that this would result in ambiguity where matched expected argument type doesn't conform to `ExpressibleByNilLiteral`. To handle situations like this locator for contextual mismatch has to be adjusted to point to the call where `nil` is used, so `diagnoseAmbiguityWithFixes` can identify multiple overloads and produce a correct ambiguity diagnostic. Resolves: rdar://75514153 (cherry picked from commit 29cb7dd)
|
@swift-ci please test |
|
Original is #37178 |
airspeedswift
approved these changes
May 7, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
nilis passed as an argument to call with multiple overloadsit's possible that this would result in ambiguity where matched
expected argument type doesn't conform to
ExpressibleByNilLiteral.To handle situations like this locator for contextual mismatch
has to be adjusted to point to the call where
nilis used, sodiagnoseAmbiguityWithFixescan identify multiple overloads andproduce a correct ambiguity diagnostic.
Scope: Invalid expressions where
nilis passed to an incompatible parameterResolves: rdar://75514153
Risk: Very low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://75514153