[SILGen] Fix a miscompile when emitting the application of a wrapped parameter #37301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
May 7, 2021
… wrapped or projected value in RValueEmitter::visitAppliedPropertyWrapperExpr
hborla
force-pushed
the
wrapped-parameter-miscompile
branch
from
03230ef to
0999dea
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass down the
SGFContextwhen emitting the r-value of the argument to the property wrapper generator function. This silly mistake caused a miscompile when the argument to the property wrapper initializer contains address-only types (e.g. resilient types). TheSGFContextpassed tovisitAppliedPropertyWrapperExprhad the emit-into buffer for the result ofemitApplyOfPropertyWrapperBackingInitializer. If the argument to the backing initializer was an address-only type, it was incorrectly initialized in place. Because this wasn't theRValuereturned byvisitAppliedPropertyWrapperExpr, the caller would overwrite the buffer with the correct result, which meant that the r-value of the argument ended up not being emitted.Without this change, the added test case fails in the SIL verifier with:
Thanks to @slavapestov for helping me understand what was going wrong here.
Resolves: rdar://77572130