Revise doc comments for continuations #37303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For rdar://77331481
|
@swift-ci please smoke test |
ktoso
reviewed
May 13, 2021
Per tech review from @ktoso
Conflicts were just @Availability marker changes.
|
@swift-ci please smoke test |
For rdar://77331481
jckarter
reviewed
May 13, 2021
jckarter
reviewed
May 13, 2021
Per tech review from @jckarter
jckarter
reviewed
May 13, 2021
jckarter
approved these changes
May 13, 2021
|
@swift-ci Please test and merge. |
ktoso
reviewed
May 14, 2021
| @@ -251,6 +271,18 @@ public func withCheckedContinuation<T>( | |||
| } | |||
| } | |||
|
|
|||
| /// Suspends the current task, | |||
| /// then calls the given closure with a checked throwing continuation for the current task. | |||
There was a problem hiding this comment.
oh wait, that's not quite right.
We don't unconditionally suspend here do we?
This is just a potential suspension point and if it is immediately resumed we never suspended, or did I get that wrong @jckarter ?
There was a problem hiding this comment.
From our discussion, we'll dig into this detail and fix separately if this wording isn't correct. Asking CI to test & merge as-is.
There was a problem hiding this comment.
Okey it seems the wording is correct :)
|
@swift-ci Please test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note two tech review queries marked ◊TR in the diff.
For rdar://76086293