[5.5][Sema] Don’t allow unresolved type variables if LeaveBraceStmtBodyUnchecked is true
#37309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checked` is `true` According to Pavel, we want to eliminate allowing unresolved variables as much as possible. Removing this flag doesn’t break any test cases (at least not in a meaningful way) and fixes a crasher, so it seems reasonable to remove it. Fixes rdar://76686564
…or completion When doing operator completion, we re-type-check the sequence expression. If we have an unresolve type already applied to `ParsedExpr`, which is the last element of the sequence, the type checker crashes in `validation-test/IDE/crashers_2_fixed/0008-must-conform-to-literal-protocol.swift`, because there are still inactive constraints in the constraint system when it finishes solving. Previously, we would ignore because we allowed free type variables, which we no longer do since the last commit.
|
@swift-ci Please test |
akyrtzi
approved these changes
May 7, 2021
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
May 10, 2021
Remove the `TypeCheckExprFlags::AllowUnresolvedTypeVariables` flag, fixing another occurance of rdar://76686564 (swiftlang#37309) This does not break anything in the test suite, so I think the removal of the flag is fine. Resolves rdar://76686564 and rdar://77659417
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
May 11, 2021
Remove the `TypeCheckExprFlags::AllowUnresolvedTypeVariables` flag, fixing another occurance of rdar://76686564 (swiftlang#37309) This does not break anything in the test suite, so I think the removal of the flag is fine. Resolves rdar://76686564 and rdar://77659417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #36943 to 5.5
According to Pavel, we want to eliminate allowing unresolved variables as much as possible. Removing this flag doesn’t break any test cases (at least not in a meaningful way) and fixes a crasher, so it seems reasonable to remove it.
When doing operator completion, we re-type-check the sequence expression. If we have an unresolve type already applied to
ParsedExpr, which is the last element of the sequence, the type checker crashes invalidation-test/IDE/crashers_2_fixed/0008-must-conform-to-literal-protocol.swift, because there are still inactive constraints in the constraint system when it finishes solving.Previously, we would ignore because we allowed free type variables, which we no longer do since the last commit.
Fixes rdar://76686564