[5.5][TypeChecker] Clear param specifiers before re-typechecking expression for completion #37310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for completion Because we are completing inside a result builder, we are never calling into `typeCheckExpression` and thus never call into `typeCheckForCodeCompletion` before `fallbackTypeCheck` (SR-14601). This works fine in most cases, but in the added test case, we are hitting an assertion because the specifiers are not correctly erased from the `ClosureExpr` before re-typechecking for completion. Erasing them before fixes the test case until the underlying issue described above is fixed. Fixes rdar://76710904 [SR-14494]
|
@swift-ci Please test |
|
Build failed |
|
macOS timed out. Meant to request macOS testing again, but accidentally requested all. @swift-ci Please test |
akyrtzi
approved these changes
May 7, 2021
AnthonyLatsis
added
swift 5.5
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking #36992 to 5.5
Because we are completing inside a result builder, we are never calling into
typeCheckExpressionand thus never call intotypeCheckForCodeCompletionbeforefallbackTypeCheck(SR-14601).This works fine in most cases, but in the added test case, we are hitting an assertion because the specifiers are not correctly erased from the
ClosureExprbefore re-typechecking for completion. Erasing them before fixes the test case until the underlying issue described above is fixed.Fixes rdar://76710904 [SR-14494]