[CodeCompletion] Reset 'hasSingleExpressionBody' when setting function body #37324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
May 7, 2021
test/SourceKit/CodeComplete/complete_sequence_rdar75358153.swift
Outdated
Show resolved
Hide resolved
…n body
Previously, completing inside non single expression body might cause a
crash if you had done any completion with single expression in the same
body.
e.g.
func test() {
test(#^HERE^#)
}
after that:
func test() {
test(arg)
if #^HERE^#
}
That was because the `hasSingleExpressionBody` wasn't cleared when
reusing the function for subsequent completions.
This patch just clears it whenever a new parsed body is set to a
function.
rdar://75358153
rintaro
force-pushed
the
ide-completion-rdar75358153
branch
from
443a0d2 to
72f16df
Compare
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, completing inside non single expression body might cause a crash if you had done any completion with single expression in the same body.
e.g.
after that:
That was because the
hasSingleExpressionBodyflag wasn't cleared when reusing the function for subsequent completions.This patch just clears it whenever a new parsed body is set to a function.
rdar://75358153