[ResultBuilders] Diagnose pre-check errors inline #37342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all of the pre-check errors could be diagnosed by re-running `PreCheckExpression` e.g. key path expressions are mutated to a particular form after an error has been produced. To make the behavior consistent, let's allow pre-check to emit diagnostics and unify pre-check and constraint generation fixes. Resolves: rdar://77466241
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
|
I should have mentioned that in the description :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of the pre-check errors could be diagnosed by re-running
PreCheckExpressione.g. key path expressions are mutated toa particular form after an error has been produced.
To make the behavior consistent, let's allow pre-check to emit
diagnostics and unify pre-check and constraint generation fixes.
Resolves: rdar://77466241