Skip to content

[5.5][CodeCompletion] Complete pattern introducer for 'for' #37346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

[5.5][CodeCompletion] Complete pattern introducer for 'for' #37346

merged 1 commit into from
May 11, 2021

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 10, 2021 •
edited
Loading

Cherry-pick #37300 into release/5.5

  • Explanation: Code completion update for SE-0298 Async/Await sequences. SE-0298 introduced async/await sequences. Now users can write await before the pattern part of for statements. This PR add code completion support for it. suggest async, try, var, and case right after for.
  • Scope: Code completion after for keyword
  • Risk: Low
  • Issue: rdar://76355581
  • Testing: Added regression test cases
  • Reviewer: Ben Langmuir (@benlangmuir)

@rintaro
[CodeCompletion] Complete pattern introducer for 'for'
2208ee7 
After 'for', suggest 'try', 'await', 'var' and 'case'.

rdar://76355581
(cherry picked from commit b348bf6)
@rintaro rintaro requested a review from a team as a code owner May 10, 2021 19:31
@rintaro
Copy link
Member Author

rintaro commented May 10, 2021

@swift-ci Please test

@rintaro rintaro changed the title [CodeCompletion] Complete pattern introducer for 'for' [5.5][CodeCompletion] Complete pattern introducer for 'for' May 10, 2021
@rintaro rintaro added the r5.5 label May 10, 2021
@rintaro rintaro merged commit a57db3f into swiftlang:release/5.5 May 11, 2021
@rintaro rintaro deleted the 5.5-ide-completion-rdar76355581 branch May 11, 2021 16:27
@AnthonyLatsis AnthonyLatsis added swift 5.5 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @airspeedswift @AnthonyLatsis