Skip to content

[5.5][CodeCompletion] Make object literals optional #37366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 11, 2021

Cherry-pick #37330 into release/5.5

  • Explanation: Non-Darwin platforms don't want object literals (i.e. #colorLiteral(red:green:blue":alpha:) and #imageLiteral(named:)) in code completion. Make it optional and default it true
  • Scope: code completion
  • Risk: Low
  • Testing: Added regression test cases
  • Issue: rdar://75620636
  • Reviewer: Ben Langmuir (@benlangmuir)

@rintaro rintaro added the r5.5 label May 11, 2021
@rintaro rintaro requested a review from a team as a code owner May 11, 2021 17:25
@rintaro
Copy link
Member Author

rintaro commented May 11, 2021

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1e9a65d8117b3674e453b30275f6e8da8e326c65

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1e9a65d8117b3674e453b30275f6e8da8e326c65

For example, non-Darwin platforms probably don't want
`#colorLiteral(red:green:blue":alpha:)` and `#imageLiteral(named:)`.
Add an completion option to include them, which is "on" by default.

rdar://75620636
(cherry picked from commit da96ef1)
@rintaro rintaro force-pushed the 5.5-ide-completion-rdar75620636 branch from 1e9a65d to 8b65d0d Compare May 11, 2021 19:27
@rintaro
Copy link
Member Author

rintaro commented May 11, 2021

@swift-ci Please test

@rintaro rintaro merged commit ccb7d76 into swiftlang:release/5.5 May 12, 2021
@rintaro rintaro deleted the 5.5-ide-completion-rdar75620636 branch May 12, 2021 01:17
@AnthonyLatsis AnthonyLatsis added swift 5.5 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants