Skip to content

SIL: support dealloc_ref and dealloc_partial_ref in LoadBorrowImmutabilityChecker #37371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

gottesmm
Copy link
Contributor

It fixes a verifier crash.

Thanks to @compnerd, who found this by experiment.

(cherry picked from commit 4cd3171)

rdar://77644532 SR-14594

…ilityChecker

It fixes a verifier crash.

Thanks to @compnerd, who found this by experiment.

(cherry picked from commit 4cd3171)
@gottesmm gottesmm requested review from atrick and eeckstein May 11, 2021 19:20
@gottesmm gottesmm requested a review from a team as a code owner May 11, 2021 19:20
@gottesmm
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 70091a2

@gottesmm
Copy link
Contributor Author

@swift-ci clean test linux platform

@gottesmm
Copy link
Contributor Author

windows test is failing on CXX tests. I believe they just were not updated for the platform. Not caused by this change.

@gottesmm
Copy link
Contributor Author

#37378 contains disables for the windows breakage on 5.4. cxx importer is an experimental feature/compnerd is ok with me disabling it only on 5.4.

@shahmishal
Copy link
Member

@swift-ci test Windows

@shahmishal shahmishal merged commit bfb5ccd into swiftlang:release/5.4 May 17, 2021
@gottesmm gottesmm deleted the release/5.4-77644532 branch May 18, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants