Skip to content

[swift-inspect] Start at least building swift-inspect on Darwin. #37377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

Just for testing for now.

@gottesmm gottesmm requested review from shahmishal and mikeash May 11, 2021 23:46
@gottesmm
Copy link
Contributor Author

@shahmishal What do you think?

@gottesmm
Copy link
Contributor Author

@swift-ci test

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

Already passed, just want to check that we actually built it.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8fa12de3f1c30ef7e5bc0e424675ba2b9fce199f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8fa12de3f1c30ef7e5bc0e424675ba2b9fce199f

@gottesmm
Copy link
Contributor Author

@swift-ci test macOS platform

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm
Copy link
Contributor Author

@mikeash one thing we may want to do is make this use the shared swiftpm build root. I think you are building ArgumentParser for the Nth time. I still think enabling this in the short terms good. I checked the macOS build and it did build swift inspect. That way we at least know it keeps working.

@mikeash
Copy link
Contributor

mikeash commented May 19, 2021

Makes sense to me. How hard is it to make it use the shared build root?

@gottesmm
Copy link
Contributor Author

Not much. It is easy to fix.

@gottesmm
Copy link
Contributor Author

@mikeash looks like swift inspect doesn't work on Linux. (Windows it isn't built).

…latforms.

It isn't setup appropriately to build on Linux. But at least this will keep the
Darwin side working.
@gottesmm gottesmm force-pushed the pr-7a3f0558480d03ca06a09cf60d99496bb79c7e82 branch from 8fa12de to 2bdb681 Compare May 19, 2021 22:57
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm changed the title [swift-inspect] Start at least building swift-inspect on all platforms. [swift-inspect] Start at least building swift-inspect on Darwin. May 20, 2021
@gottesmm
Copy link
Contributor Author

I was wrong about the shared root. I thought we had more infrastructure for it. I am going to look into it in the future. Not much increase in compile time overall though.

@gottesmm gottesmm merged commit 7cc0019 into swiftlang:main May 20, 2021
@gottesmm gottesmm deleted the pr-7a3f0558480d03ca06a09cf60d99496bb79c7e82 branch May 20, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants