Remove -enable-protocol-typealiases staging flag #3738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Awesome! Thanks for all your work on this! |
|
You did most of it, so thank you! |
slavapestov
force-pushed
the
remove-protocol-typealias-flag
branch
from
1015d8b to
fb43897
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
remove-protocol-typealias-flag
branch
from
fb43897 to
d474a45
Compare
|
@swift-ci Please test |
It looks like migration fixits are done, and this doesn't expose any new bugs that were not possible before, because you could already define typealiases inside protocol extensions. To prevent some compiler_crasher regressions, add a simple circularity-breaking hack. I'll need to do a sweep to clean these up some day soon.
slavapestov
force-pushed
the
remove-protocol-typealias-flag
branch
from
d474a45 to
1ae8e37
Compare
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.