Skip to content

[5.5] Enable swift-driver forwarding on non-Apple platforms. #37385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 12, 2021

Cherry-pick of: #37290

This removes the #ifdef APPLE guard that restricts this forwarding to Apple platforms only.
If a given build/toolchain does not build or include the swift-driver executable alongside the compiler executables, the driver will still safely default to the legacy driver.

Resolves rdar://75534188

This removes the `#ifdef __APPLE__` guard that restricts this forwarding to Apple platforms only.
If a given build/toolchain does not build or include the `swift-driver` executable alongside the compiler executables, the driver will still safely default to the legacy driver.

Resolves rdar://75534188
@artemcm artemcm added the r5.5 label May 12, 2021
@artemcm artemcm requested a review from nkcsgexi May 12, 2021 16:48
@artemcm artemcm requested a review from a team as a code owner May 12, 2021 16:48
@artemcm
Copy link
Contributor Author

artemcm commented May 12, 2021

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 04116bc

@artemcm
Copy link
Contributor Author

artemcm commented May 12, 2021

@swift-ci please test Linux platform

@airspeedswift airspeedswift merged commit 1415b90 into swiftlang:release/5.5 May 13, 2021
@artemcm artemcm deleted the CherryPickDriverForwardingNonApple branch December 16, 2022 17:37
@AnthonyLatsis AnthonyLatsis added swift 5.5 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants