Delete Flaky IR Hash Test #37386
Merged
Delete Flaky IR Hash Test #37386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our LLVM backend is supposed to have a build-time optimization where we hash the IR and do not proceed with LLVM code generation if the hash matches the one we last used to emit any products. This has never quite worked for a variety of reasons - we fixed a number of those reasons in swiftlang#31106 but this test remained flaky for its entire lifetime. It's really not worth all the trouble to keep investigating this, so I'm removing this test. rdar://77654695
|
@swift-ci smoke test |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our LLVM backend is supposed to have a build-time optimization where we
hash the IR and do not proceed with LLVM code generation if the hash
matches the one we last used to emit any products. This has never quite
worked for a variety of reasons - we fixed a number of those reasons in
#31106 but this test remained flaky since its introduction.
It's really not worth all the trouble to keep investigating this, so I'm
removing this test.
rdar://77654695