[5.5][CSSimplify] Increase fix impact when passing closure to a non-function type parameter #37388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on type parameter In overloaded context it's possible that there is an overload that expects a closure but it can have other issues e.g. different number of parameters, so in order to pick a better solution let's always increase a score for overloads where closure is matched against a non-function type parameter. Also a note which points out where exactly anonymous parameters are used in the multi-statement body is helpful to identify problematic and fix the issue. Resolves: rdar://76058892
|
@swift-ci please test |
airspeedswift
approved these changes
May 13, 2021
AnthonyLatsis
added
swift 5.5
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #37373
Improve a diagnostic when a closure is used as an argument in an overloaded call.
In overloaded context it's possible that there is an overload that
expects a closure but it can have other issues e.g. different number
of parameters, so in order to pick a better solution let's always
increase a score for overloads where closure is matched against a
non-function type parameter. Also a note which points out where
exactly anonymous parameters are used in the multi-statement
body is helpful to identify problematic and fix the issue.
Scope: Invalid overloaded calls where one of the overloads accepts a closure but has different number of parameters or some other type issue.
Main Branch PR: [CSSimplify] Increase fix impact when passing closure to a non-function type parameter #37373
Resolves: rdar://76058892
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://76058892