[5.5][Refactoring] Avoid redeclarations or shadowing in async refactored code #37400
Conversation
When converting a call or function, rename declarations such that redeclaration errors and shadowing are avoided. In some cases this will be overly conservative, but since any renamed variable can be fixed with edit all in scope, this is preferred over causing redeclaration errors or possible shadowing. Resolves rdar://73973517
bnbarham
changed the title
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
Another spurious failure.. @swift-ci please test Linux platform |
|
@swift-ci please nominate --- CCC --- Explanation: When performing the convert to async refactoring (whether on a call or function), declarations are hoisted out of the closure and into the parent scope. This can introduce potential redeclarations and/or shadowing. It's also actually a common occurrence in completion handler code - nested calls often have the same name closure argument names, eg. "res"/"result". This change renames the declarations in hoisted code so that redeclarations/shadowing are avoided. Radar/SR Issue: rdar://73973517 Risk: Low - only affects the async refactoring Testing: Added new test cases to the refactoring test suite |
AnthonyLatsis
added
swift 5.5
🍒 release cherry pick
Cherry-picking #37302
When converting a call or function, rename declarations such that
redeclaration errors and shadowing are avoided. In some cases this will
be overly conservative, but since any renamed variable can be fixed with
edit all in scope, this is preferred over causing redeclaration errors
or possible shadowing.
Resolves rdar://73973517