[5.5][Refactoring] Add @completionHandlerAsync to sync function #37418
Conversation
bnbarham
changed the title
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
Fixes:
sys.stdout.write(dump_text_output)
TypeError: write() argument must be str, not bytes
When adding an async alternative, add the @completionHandlerAsync attribute to the sync function. Check for this attribute in addition to the name check, ie. convert a call if the callee has either @completionHandlerAsync or a name that is completion-handler-like name. The addition of the attribute is currently gated behind the experimental concurrency flag. Resolves rdar://77486504
bnbarham
force-pushed
the
5.5-cherry-rdar77486504
branch
from
b73c4f8 to
3c0bb38
Compare
|
@swift-ci please test |
|
@swift-ci please nominate --- CCC --- Explanation: Add a "@completionHandlerAsync" attribute to the sync function when performing the "Add Async Alternative" refactoring and experimental concurrency features are enabled with -enable-experimental-concurrency. Have the function conversion check if this attribute is on the callee of a callsite when deciding whether to convert it (in addition to the existing name check). Adding the attribute also enables a warning when that function is used in an async context (already used for implicitly imported ObjectiveC async functions). Radar/SR Issue: rdar://77486504 Risk: Very low - only affects the async refactoring and only when experimental concurrency features are enabled. Testing: Added new test cases to the refactoring test suite |
AnthonyLatsis
added
🍒 release cherry pick
Cherry-picks #37358 (to avoid a merge conflict) and #37417
When adding an async alternative, add the @completionHandlerAsync
attribute to the sync function. Check for this attribute in addition to
the name check, ie. convert a call if the callee has either
@completionHandlerAsync or a name that is completion-handler-like name.
The addition of the attribute is currently gated behind the experimental
concurrency flag.
Resolves rdar://77486504