Provide doc comments for AsyncSequence and related types (for release branch) #37420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First draft docs for iterator, sequence type. Also drop(while:), to get a feel for the AsyncSequence->AsyncSequence cases. * Source docs for contains and reduce. * Docs for methods in AsyncSequence. This covers all the methods that return a single value. Still working on the extension methods that return new sequences. * Early source docs for dropFirst(_:) and its type * Correct doc format for dropFirst(_:). * Prefix, plus some fixes. * Docs for prefix(while:). * Apply Philippe's snippet fixes. * First draft docs on the map sequences. Plus miscellaneous fixes throughout. * Show result of flatMap example. * More explicit cancellation guidance. * Convert snippets to trailing closures. * Correct misplaced doc comments. * Apply suggestions from code review Co-authored-by: Philippe Hausler <[email protected]> * Apply editorial feedback. * Apply additional editorial feedback. * Apply suggestions from code review Co-authored-by: bjlanier <[email protected]> * Apply further editorial feedback. Co-authored-by: Chris Adamson <[email protected]> Co-authored-by: Philippe Hausler <[email protected]> Co-authored-by: bjlanier <[email protected]>
|
@swift-ci please clean smoke test |
invalidname
changed the title
invalidname
changed the title
tkremenek
approved these changes
May 14, 2021
bjlanier
approved these changes
May 14, 2021
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source documentation for
AsyncSequence, its helper types, and extension methods. (Already landed tomainin #37383, this is a cherry-pick torelease/5.5).