Skip to content

[5.5] Test Only - Do not load Concurrency modile in batch_module_scan_versioned #37427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 14, 2021

Cherry-pick of #37089

It has a specific target (x86_64) and on other platforms, Concurrency will not be found with this architecture by default.
e.g. Apple Silicon failure:
https://ci.swift.org/job/oss-swift-5.5-incremental-RA-macos-apple-silicon/112/consoleFull#12337284463122a513-f36a-4c87-8ed7-cbc36a1ec144

…ioned`

It has a specific target (`x86_64`) and on other platforms, Concurrency will not be found with this architecture by default.
e.g. Apple Silicon failure:
https://ci.swift.org/job/swift-PR-macos-apple-silicon/78
@artemcm artemcm added the r5.5 label May 14, 2021
@artemcm artemcm requested a review from atrick May 14, 2021 18:59
@artemcm
Copy link
Contributor Author

artemcm commented May 14, 2021

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Force-merging since this only affects one test.

@atrick atrick merged commit eb5378d into swiftlang:release/5.5 May 14, 2021
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 894827b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 894827b

@artemcm artemcm deleted the FixBatchScanTestConcurrencyImport branch December 16, 2022 17:37
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.5 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants