C++ Interop: import namespace aliases #37443
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
Looked over changes. LGTM but I am pretty green on this project. @zoecarver What do you think? |
| namespace GlobalAliasToNS1 = ClassesNS1; | ||
|
|
||
| namespace ClassesNS4 { | ||
| namespace AliasToGlobalNS1 = ::ClassesNS1; | ||
| namespace AliasToGlobalNS2 = ::ClassesNS1::ClassesNS2; | ||
|
|
||
| namespace ClassesNS5 { | ||
| struct BasicStruct {}; | ||
| } // namespace ClassesNS5 | ||
|
|
||
| namespace AliasToInnerNS5 = ClassesNS5; | ||
| namespace AliasToNS2 = ClassesNS1::ClassesNS2; | ||
|
|
||
| namespace AliasChainToNS1 = GlobalAliasToNS1; | ||
| namespace AliasChainToNS2 = AliasChainToNS1::ClassesNS2; | ||
| } // namespace ClassesNS4 | ||
|
|
There was a problem hiding this comment.
Are more complex test cases covered by other tests? For example, consider code with namespaces that are shadowed
namespace X { }
namespace Y { namespace X { }; namespace Z = X; /* IIUC, refers to ::Y::X */ }
or code with using namespace ABC. Do these get translated correctly?
There was a problem hiding this comment.
There wasn't a test for such case, but I've added it now. Also added a test for an alias pointing to its parent namespace, and a couple of other similar cases.
Using-directives & using-declarations currently aren't imported at all (these C++ constructs, along with inline namespaces, are among those that I don't know how to express ergonomically in Swift).
Previously they weren't imported, now they are imported as typealiases to enums representing namespaces. Fixes SR-12467.
egorzhdan
force-pushed
the
cxx-namespace-alias
branch
from
6d06597 to
51a8c47
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Windows. |
|
@swift-ci please test Windows platform. |
|
@swift-ci please test Windows. |
| @@ -40,4 +40,35 @@ struct BasicStruct { | |||
| }; | |||
| } // namespace ClassesNS3 | |||
|
|
|||
| namespace GlobalAliasToNS1 = ClassesNS1; | |||
There was a problem hiding this comment.
I was going to suggest a test that references a namespace in another module, but I think we need to sort out SR-14214 first.
Previously they weren't imported, now they are imported as typealiases to enums representing namespaces.
Fixes SR-12467.