Skip to content

[Runtime] Remove FIXMEs and hacks for tail calls. #37461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2021
Merged

[Runtime] Remove FIXMEs and hacks for tail calls. #37461

merged 1 commit into from
May 18, 2021

Conversation

varungandhi-apple
Copy link
Contributor

Reverts hack from 9b4f7d6.

Fixes rdar://78058239

@varungandhi-apple varungandhi-apple force-pushed the vg-fix-tail-calls branch 2 times, most recently from b2bdcb4 to 219af84 Compare May 17, 2021 19:33
aschwaighofer
aschwaighofer approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add comments to the lines that require a return explaining that they are not just cosmetic but change code emission?

@varungandhi-apple
Copy link
Contributor Author

Added comments where explicit return is used to force a tail call.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci test

@aschwaighofer
Copy link
Contributor

Thank you

@varungandhi-apple varungandhi-apple mentioned this pull request May 17, 2021
Merged
@varungandhi-apple varungandhi-apple merged commit de221dd into swiftlang:main May 18, 2021
@varungandhi-apple varungandhi-apple deleted the vg-fix-tail-calls branch May 18, 2021 16:30
@aschwaighofer aschwaighofer mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungandhi-apple @aschwaighofer