[sil][debug-info] Refactor SILInstruction SILLocation verification out of SILVerifier onto a helper/use to verify in SILBuilder #37468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
force-pushed
the
sil-debug-info-more-verification
branch
from
070bc44 to
7d60941
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
atrick
approved these changes
May 18, 2021
| @@ -95,7 +95,7 @@ class SILDebugScope : public SILAllocated<SILDebugScope> { | |||
| }; | |||
|
|
|||
| /// Determine whether an instruction may not have a SILDebugScope. | |||
| bool maybeScopeless(SILInstruction &I); | |||
| bool maybeScopeless(const SILInstruction &inst); | |||
There was a problem hiding this comment.
Weird API name. It should be requiresDebugScope
gottesmm
force-pushed
the
sil-debug-info-more-verification
branch
from
7d60941 to
38e6c6f
Compare
adrian-prantl
approved these changes
May 18, 2021
|
@swift-ci test |
|
Build failed |
|
Build failed |
…gument. This function only uses the reference in a const way, so nothing changes functionally, we can just pass it into contexts where we have a const reference without fighting the compiler.
…on of debug info on SILInstructions into a method on SILInstruction. The verifier just invokes this method, so we aren't losing any verification in the SILVerifier itself. The reason why I am extracting this information into a helper is that often times one hits these structural assertions in the verifier making one have to track down where in a pass the bad location was actually inserted. To make these easier to find, I am going to change the SILBuilder to invoke these structural comparisons so that we can catch these problems at the call site making it easier to fix code.
…tructurally with the provided SILLocation. These checks used to be in the SILVerifier only so one had to drop down into the debugger to figure out where a pass actually introduced the bad location. With this change, we abort immediately in the place in the code where the problem happens allowing for one to quickly fix the problems.
gottesmm
force-pushed
the
sil-debug-info-more-verification
branch
from
38e6c6f to
e88134b
Compare
|
@swift-ci test |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that we catch these issues earlier when they are introduced rather than after a pass that introduced the problem finished running (and we run the verifier).