[Sema] Shepherd @manavgabhawala's changes to circular protocol diagnostics #3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r protocol inheritance The IterativeTypeChecker now use loops instead of recursion to help keep the stack size low We diagnose circular dependencies for protocols in a more efficient manner and also prevent the possibility of infinite loops
CodaFi
force-pushed
the
circumnavigating-a-graph-in-eighty-days
branch
2 times, most recently
from
09742fa to
b384aa9
Compare
| @@ -5,7 +5,7 @@ | |||
| // See http://swift.org/LICENSE.txt for license information | |||
| // See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | |||
|
|
|||
| // RUN: not %target-swift-frontend %s -parse | |||
| // RUN: not --crash %target-swift-frontend %s -parse | |||
There was a problem hiding this comment.
Hm. Is it worth figuring out why this one regressed?
There was a problem hiding this comment.
Nevermind, false alarm. I must have moved the wrong tests.
CodaFi
force-pushed
the
circumnavigating-a-graph-in-eighty-days
branch
from
b384aa9 to
f8fa87a
Compare
|
Let's get some sanity here. @swift-ci please test OS X platform. |
|
This passed linux tests before I futzed around with the crash tests. |
Closed
1 task
kateinoigakukun
pushed a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
#2123's type checker changes were causing an infinite loop, but the rest of the changes related to circular protocol diagnostics are still valuable to have. This will pull them in and leave the type checker alone for now.
h/t @rintaro
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.