[5.5][Serialization] Do not assert when inherited type is null #37476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with allow errors, it's possible to have invalid inherited types - both null and ErrorType. Cleaned up the tests a little - moved the majority of Frontend/allow-errors.swift into separate files in Serialization/AllowErrors and use split_file.py instead of #defines. Resolves rdar://78048470
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Didn't notice these failed, don't think I got an email with them 🤔. Jobs deleted now so just going to run again. @swift-ci please test |
|
Build failed |
|
Build failed |
There was a change in the diagnostics that isn't in 5.5. The error message itself doesn't matter too much here, just that there was one. Simplify the CHECK clause so that it will pass in main and 5.5 to avoid future conflicts.
|
@swift-ci please test |
akyrtzi
approved these changes
May 20, 2021
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #37441
When compiling with allow errors, it's possible to have invalid
inherited types - both null and ErrorType.
Cleaned up the tests a little - moved the majority of
Frontend/allow-errors.swift into separate files in
Serialization/AllowErrors and use split_file.py instead of #defines.
Resolves rdar://78048470