[5.4][SourceKit] Verify the stdlib is loaded before creating an AST #37483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen a couple of crashes that look like they are being caused by `sourcekitd` being unable to load the Swift stdlib. Emit a proper error message explaining the issue instead of crashing. This change assumes that all sourcekitd requests that create an AST require the stdlib. IMHO this is a reasonable assumption. Fixes rdar://75740572 by catching the crash in the new check.
|
@swift-ci Please test |
|
@swift-ci Please nominate |
|
@swift-ci Please nominate |
akyrtzi
approved these changes
May 18, 2021
AnthonyLatsis
added
swift 5.4
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #36797 to
release/5.4.sourcekitdis unable to load the stdlib, report an error and fail early instead of trying to compile and crashing somewhere in the type checker because required types from the standard library cannot be found.sourcektidrequests that are unable to load the standard library