[AST] Improve BinaryExpr #37501
Merged
[AST] Improve BinaryExpr #37501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract away the TupleExpr gunk and expose `getLHS` and `getRHS` accessors. This is in preparation for completely expunging the use of TupleExpr as an argument list.
|
@swift-ci please test |
CodaFi
reviewed
May 19, 2021
|
|
||
| return getTypeOfCompletionOperatorImpl(DC, &binaryExpr, | ||
| referencedDecl); | ||
| auto *binaryExpr = BinaryExpr::create(DC->getASTContext(), LHS, opExpr, |
There was a problem hiding this comment.
Oh right, that place we make expression nodes on the stack.
Is there any worry about ASTContext heap growth here? My thought is no since this is, what, at most a handful of words per expr...
There was a problem hiding this comment.
I think it's okay, I mean we already allocate an ASTNode for the TupleExpr here, and will allocate other nodes for the earlier call to resolveDeclRefExpr, not to mention all the nodes creating while parsing and type-checking. And even during cached code completion, we throw away the ASTContext after a fixed number of completions, so the growth should never be unbounded I believe.
CodaFi
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract away the TupleExpr gunk and expose
getLHSandgetRHSaccessors. This is in preparation for completely expunging the use of TupleExpr as an argument list (#37435).