[cmake] Add support for checking if we have a host toolchain Swift compiler #37511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpiler. This just causes us to perform the cmake check. It isn't used anywhere.
|
@swift-ci test |
|
@swift-ci test windows platform |
compnerd
reviewed
May 19, 2021
Comment on lines
+62
to
+63
| message(STATUS "WARNING! Did not find a host compiler swift?! Can not build | ||
| any compiler host sources written in Swift") |
There was a problem hiding this comment.
Suggested change
| message(STATUS "WARNING! Did not find a host compiler swift?! Can not build | |
| any compiler host sources written in Swift") | |
| message(WARNING "Did not find a host compiler swift. Can not build any compiler host sources written in Swift") |
There was a problem hiding this comment.
I think it may be nice to sink this lower to the point of use.
There was a problem hiding this comment.
Mind if I do that in a follow on?
|
I will fix that as follow on. |
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
May 25, 2021
This mimicks the same logic used for shared libraries a few lines above. This will allow the minimal freestanding stdlib to build with swiftlang#37511 Addresses rdar://78336832
edymtt
added a commit
that referenced
this pull request
May 26, 2021
This mimicks the same logic used for shared libraries a few lines above. This will allow the minimal freestanding stdlib to build with #37511, solving errors like ``` ninja: error: build.ninja:4213: multiple rules generate stdlib/public/SwiftOnoneSupport/CMakeFiles/ swiftSwiftOnoneSupport-freestanding-x86_64-static.dir/__/__/ linker-support/magic-symbols-for-install-name.c.o [-w dupbuild=err] ``` Addresses rdar://78336832
LucianoPAlmeida
pushed a commit
to LucianoPAlmeida/swift
that referenced
this pull request
May 27, 2021
…g#37642) This mimicks the same logic used for shared libraries a few lines above. This will allow the minimal freestanding stdlib to build with swiftlang#37511, solving errors like ``` ninja: error: build.ninja:4213: multiple rules generate stdlib/public/SwiftOnoneSupport/CMakeFiles/ swiftSwiftOnoneSupport-freestanding-x86_64-static.dir/__/__/ linker-support/magic-symbols-for-install-name.c.o [-w dupbuild=err] ``` Addresses rdar://78336832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just causes us to perform the cmake check. It isn't used anywhere.