[SourceKit] Recover if compiler arguments have errors #37512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed twice and `-experimental-allow-module-with-compiler-errors` is passed
If the compiler arguments have errors in them (e.g. because a file with the same name is used twice), we can often still fulfill SourceKit requests because the compiler argument errors are only relevant for later stages of the compilation process. Instead of bailing out early, do a best effor retrieving the compiler arguments that are valid and ignoring the errors. Fixes rdar://77618144
ahoppen
force-pushed
the
pr/allow-driver-errors
branch
from
fc1764f to
44f8e19
Compare
ahoppen
changed the title
|
@swift-ci Please test |
akyrtzi
approved these changes
May 19, 2021
|
Build failed |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the compiler arguments have errors in them (e.g. because a file with the same name is used twice), we can often still fulfill SourceKit requests because the compiler argument errors are only relevant for later stages of the compilation process.
Instead of bailing out early, do a best effort retrieving the compiler arguments that are valid and ignoring the errors.
Also add a test case that we can create a module if same filename is used twice and
-experimental-allow-module-with-compiler-errorsis passedFixes rdar://77618144