Skip to content

[update-checkout] On Linux for main, next, and master-rebranch, bump the cmake to v3.19.6. #37517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

[update-checkout] On Linux for main, next, and master-rebranch, bump the cmake to v3.19.6. #37517

merged 1 commit into from
May 20, 2021

Conversation

gottesmm
Copy link
Contributor

This is not touching the minimum yet since we need to do a bit more work over
the next couple of weeks to get the bots ready on macOS for the newer cmake.
Windows bots already support the newer cmake.

https://forums.swift.org/t/bump-cmake-version-to-3-18/45033/10

@gottesmm
[update-checkout] On Linux for main, next, and master-rebranch, bump …
14c06d9 
…the cmake to v3.19.6.

This is not touching the minimum yet since we need to do a bit more work over
the next couple of weeks to get the bots ready on macOS for the newer cmake.
Windows bots already support the newer cmake.

https://forums.swift.org/t/bump-cmake-version-to-3-18/45033/10
@gottesmm gottesmm requested review from compnerd and shahmishal May 20, 2021 00:03
shahmishal
shahmishal approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Please don't merge this until CI nodes are updated too.

@gottesmm
Copy link
Contributor Author

@shahmishal this won't matter since it will just effect the Linux bots. Won't effect the other bots.

@gottesmm
Copy link
Contributor Author

@swift-ci test

@shahmishal
Copy link
Member

@shahmishal this won't matter since it will just effect the Linux bots. Won't effect the other bots.

We have jobs which don't use update-checkout, so I will need to run different automation to update the tags.

@finagolfin finagolfin mentioned this pull request May 20, 2021
Merged
@shahmishal
Copy link
Member

Jobs updated:

7. OSS - LLDB - ASAN + UBSAN macOS (main) (Release)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
5. OSS - LLDB Incremental - Ubuntu 16.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
6. OSS - LLDB Incremental - Ubuntu 18.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
4. OSS - LLDB Incremental - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
OSS - Swift Package Trigger (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift ASAN - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift ASAN - Ubuntu 16.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - Ubuntu 16.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - Ubuntu 16.04 - Long Test (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - Ubuntu 18.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - Ubuntu 18.04 - Long Test (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift Leaks Sanitizer - LSAN - Ubuntu 18.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - macOS (main) (Apple Silicon)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
OSS - Swift Incremental RA - macOS - Trigger (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Incremental RA - macOS (main) (Xcode)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
0. OSS - Swift Pull Request Test (status) (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
2. Swift Build Standard Library with Toolchain (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
2. Swift Build Standard Library with Toolchain (main) (minimal)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift - TSAN - libdispatch - Ubuntu 18.04 (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+No Assert,  Stdlib Opt+DebInfo, Test Simulator) - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+Assert, Stdlib DebInfo+Assert, Test Device non_executable) (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+Assert, Stdlib DebInfo+Assert, Test Simulator) - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
2. Swift (Tools Opt+Assert, Stdlib Opt+Assert) (macOS 10.14.5) (Swift in the OS)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+Assert,  Stdlib Opt+DebInfo, Test Simulator) - macOS (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Long Test) - macOS  (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Test Simulator) - macOS  (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
2. Swift Sourcekit Stress Tester (main)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6
2. Swift Sourcekit Stress Tester (main) (weekly)
	Repo: [email protected]:KitWare/CMake.git
	Branch: v3.16.5
	new Branch: v3.19.6

@shahmishal shahmishal merged commit a9948e2 into swiftlang:main May 20, 2021
@finagolfin
Copy link
Member

One question: since this only affects linux and the system CMake is used on the Mac and Win CI, what are the deployed CMake versions there? I ask because the minimum CMake version of the three is going to determine what features we can actually use going forward.

@finagolfin finagolfin mentioned this pull request May 21, 2021
Merged
@gottesmm gottesmm deleted the pr-8bb4f0e5a820f58271347bba7d6b1878741e0ac2 branch July 23, 2021 21:53
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gottesmm @shahmishal @finagolfin @compnerd @AnthonyLatsis