[Sema][Diagnostics][SR-14644] Improving diagnostics for key path with invalid components #37521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS platform |
1 similar comment
|
@swift-ci Please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adjust the
hasSingleInvalidComponentkey path expr method to only consider key path rooted on type expr because we only want to detect key paths without components e.g.\Intbecause actually key paths with invalid components like the SR example\Int.byteSwapped.signum()are represented in the AST also with a single invalid component but rooted on the whole expression. Also skips the fix for hole root key path if it has any invalid component as it would be already diagnosed.Resolves SR-14644.