Skip to content

[5.5] Future-proof the layout of AsyncTask #37531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rjmccall
Copy link
Contributor

5.5 version of #37530

@rjmccall
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 566f448d55540c0123ebc598b2926fa0918d6ac7

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 566f448d55540c0123ebc598b2926fa0918d6ac7

@rjmccall rjmccall force-pushed the future-proof-task-layout-5.5 branch from 566f448 to 4095a7f Compare May 20, 2021 23:04
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4095a7fe0b27bf47bfab3849b335ec79a01267fa

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4095a7fe0b27bf47bfab3849b335ec79a01267fa

@rjmccall rjmccall force-pushed the future-proof-task-layout-5.5 branch from 4095a7f to 7eb1052 Compare May 21, 2021 02:18
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

@rjmccall rjmccall requested a review from ktoso May 21, 2021 06:05
@rjmccall
Copy link
Contributor Author

@ktoso You approved the main version of this; mind reviewing this version as well so I can merge it?

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, LGTM.

@rjmccall rjmccall merged commit d1e865e into swiftlang:release/5.5 May 21, 2021
@rjmccall rjmccall deleted the future-proof-task-layout-5.5 branch May 21, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants