[5.5-05142021][Parse] Disallow use of actor as a declaration modifier
#37551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
`actor` is a standalone contextual keyword now and should be treated as such, `actor class` is no longer allowed and results in a parse error. Resolves: rdar://75753598 (cherry picked from commit aeddab4)
xedin
force-pushed
the
rdar-75753598-5.5-05142021
branch
from
9426f78 to
697033b
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
airspeedswift
approved these changes
May 21, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of (main) #37516, (5.5) #37550
Promote a warning into an error for declarations that use
actor classsyntax,since
actoris now a standalone contextual keyword and cannot be used asa class declaration modifier.
Scope: Declarations that still use
actor classsyntax regardless of warnings that it has been deprecated.Main Branch PR: [Parse] Disallow use of
actoras a declaration modifier #375165.5 Branch PR: [5.5][Parse] Disallow use of
actoras a declaration modifier #37550Resolves: rdar://75753598
Risk: Low
Reviewed By: @etcwilde
Testing: Regression tests added to the suite
Resolves: rdar://75753598
(cherry picked from commit aeddab4)