[SourceKit] Avoid unnecessary parsing in 'open' request #37574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
If the client doesn't want anything as the response of editor.open, avoid parsing the source because it's not necessary. rdar://77693214
rintaro
force-pushed
the
sourcekit-open-noop-rdar77693214
branch
from
4a6a376 to
4bf9682
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
benlangmuir
approved these changes
May 21, 2021
akyrtzi
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client doesn't want anything as the response of
editor.open, avoid parsing the source code because it's not necessary. We already do this foreditor.replacetextrequest, this PR just do the same thing for 'editor.open' too.rdar://77693214