[SDK] Remove the obsolete XCTest overlay #37587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My local build hasn't finished yet; I think we should be able to pick up XCTest.swiftmodule from the SDK (because we are able to link XCTest.framework), but it's possible we'll need to tweak the test configuration. @swift-ci test |
edymtt
approved these changes
May 21, 2021
|
@swift-ci test windows platform |
|
Build failed |
D'oh, I also need to remove XCTest from the expected failure list. |
The actual XCTest overlay has not been maintained in this repository for years. (It is distributed in Xcode (libXCTestSwiftSupport.dylib), along with XCTest.framework itself.) The code we have here is badly out of date, and the fact that we have it on the module path in CI makes it interfere with the contents of recent SDKs. Remove the XCTest overlay from this repository; pick it up from the SDK instead. rdar://76915582
lorentey
force-pushed
the
remove-xctest-overlay
branch
from
4657b53 to
9cf28df
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual XCTest overlay has not been maintained in this repository for years. (It is distributed in Xcode (libXCTestSwiftSupport.dylib), along with XCTest.framework itself.)
The code we have here is badly out of date, and the fact that we have it on the module path in CI makes it interfere with the contents of recent SDKs.
Remove the XCTest overlay from this repository; pick it up from the SDK instead.
rdar://76915582