Driver: correct profiling symbol preservation on Windows #37605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows linker does not support `-u`. Furthermore, the compiler driver does not forward the `-u` option to the linker. We correctly use the `/include:` option from the linker. This should ensure that the symbol is preserved even with `/opt:ref`. This spelling should be compatible with both lld and link, which should provide sufficient portability. Take the opportunity to make it more obvious that the two parameters are creating a pair that will be concatenated by using a braced initializer. See https://docs.microsoft.com/en-us/cpp/build/reference/include-force-symbol-references?view=msvc-160 for more details on the option.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows linker does not support
-u. Furthermore, the compilerdriver does not forward the
-uoption to the linker. We correctly usethe
/include:option from the linker. This should ensure that thesymbol is preserved even with
/opt:ref. This spelling should becompatible with both lld and link, which should provide sufficient
portability.
Take the opportunity to make it more obvious that the two parameters are
creating a pair that will be concatenated by using a braced initializer.
See
https://docs.microsoft.com/en-us/cpp/build/reference/include-force-symbol-references?view=msvc-160
for more details on the option.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.