Skip to content

[WIP][build] allow to pick up overlays from SDKs #37634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

[WIP][build] allow to pick up overlays from SDKs #37634

wants to merge 10 commits into from

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented May 25, 2021

  • any overlay in build folder is removed (so to be sure it's not picked up)
  • placeholder targets are created to avoid making local changes to targets that depend on overlays (like StdlibUnittest, OSLog)
    • this logic is likely to support the scenario in which the overlays are built from their own repo

@edymtt
Copy link
Contributor Author

edymtt commented Jun 14, 2021

This is no longer needed, since it was taken care of with #37823

@edymtt edymtt closed this Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde will be requested when the pull request is marked ready for review etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple will be requested when the pull request is marked ready for review justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal will be requested when the pull request is marked ready for review shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edymtt