[Refactoring] Don't crash when converting a function to async that contains a call to init #37652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
May 26, 2021
ahoppen
force-pushed
the
pr/dont-crash-call-to-init
branch
from
eca6d93 to
3c1b0d2
Compare
|
That’s what you get from copy-pasting code with tabs and setting your tab size to 2. Updated the formatting in the test case. |
…ntains a call to init We were trying to retrieve the name of all function calls in the body using `getBaseIdentifier`. But calls to `init` don’t have a base identifier, just a `DeclBaseName` (which is special). Work with the `DeclBaseName` internally to prevent the crash. Fixes rdar://78024731 [SR-14637]
ahoppen
force-pushed
the
pr/dont-crash-call-to-init
branch
from
3c1b0d2 to
58be2bf
Compare
|
@swift-ci Please test Linux |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to retrieve the name of all function calls in the body using
getBaseIdentifier. But calls toinitdon’t have a base identifier, just aDeclBaseName(which is special). Work with theDeclBaseNameinternally to prevent the crash.Fixes rdar://78024731 [SR-14637]