Sema: Allow @objc enums without -enable-objc-interop or importing Foundation #37661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
objc-enum-on-linux
branch
from
69af48e to
562abde
Compare
…ndation We used to allow @objc enums on Linux, where Objective-C interop is disabled, because the check first looked for an import of the Foundation module (which could be the non-Objective-C corelibs-foundation) before checking if Objective-C interop was enabled. Since @objc enums don't actually depend on Foundation or Objective-C and only have a different layout in IRGen, let's bring back and formalize the old behavior. Fixes https://bugs.swift.org/browse/SR-14548 / rdar://problem/77325078.
slavapestov
force-pushed
the
objc-enum-on-linux
branch
from
562abde to
30f038a
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
Cherry-picked to 5.5 here: #37664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to allow @objc enums on Linux, where Objective-C interop is disabled,
because the check first looked for an import of the Foundation module
(which could be the non-Objective-C corelibs-foundation) before checking
if Objective-C interop was enabled.
Since @objc enums don't actually depend on Foundation or Objective-C and
only have a different layout in IRGen, let's bring back and formalize the
old behavior.
Fixes https://bugs.swift.org/browse/SR-14548 / rdar://problem/77325078.