Flip the switch on 'private' and 'fileprivate'. #3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jrose-apple
force-pushed
the
private-and-fileprivate
branch
from
f22ba63 to
80d5d64
Compare
|
@swift-ci Please test OS X platform |
jrose-apple
force-pushed
the
private-and-fileprivate
branch
from
80d5d64 to
bbd0085
Compare
|
@swift-ci Please test |
jrose-apple
force-pushed
the
private-and-fileprivate
branch
from
bbd0085 to
a4f617c
Compare
|
@swift-ci Please test |
jrose-apple
force-pushed
the
private-and-fileprivate
branch
from
a4f617c to
4240315
Compare
More tests to come soon. In particular, validation of members used in protocol conformances is still not correct.
jrose-apple
force-pushed
the
private-and-fileprivate
branch
from
4240315 to
6dea23a
Compare
|
@swift-ci Please test |
|
The Foundation failure on Linux is also happening on master, and this passed a previous full test on Linux. @swift-ci Please smoke test Linux platform |
|
@swift-ci Please smoke test Linux platform |
1 similar comment
|
@swift-ci Please smoke test Linux platform |
|
The OS X failure is an unrelated PlaygroundLogger issue. I'm going to merge this anyway if the Linux smoke test passes. |
|
@abertelrud let me know that the smoke test failure is also unrelated. Since not landing this is a maintenance burden, I'm going to merge. (And I checked with @najacque, and promised to fix any fallout on any of our subprojects.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activates the main feature of SE-0025: scoped
private! Tests to come shortly, but I wanted to start CI off early.There's still a bit of cleanup to do after this commit, but this is the main feature.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.