🍒[5.5][TaskLocals] dont crash checking for taskgroup when in no task #37682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
ktoso
changed the title
|
@swift-ci please smoke test |
|
resolves rdar://78587643 |
|
@swift-ci please nominate |
|
@swift-ci please test |
DougGregor
approved these changes
May 28, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #37681
Explanation:
Fixes crash when a task local value is attempted to be bound from a context that has no Task available.
The underlying implementation is correct and works fine, but we added an additional check recently and missed that the test still had a task available.
Scope: Binding a task-local value in purely synchronous code.
Main Branch PR: #37681
Resolves: rdar://78587643
Risk: Low
Reviewed By: @DougGregor
Testing: Test adjusted to cover the specific case, previously it accidentally still had a task available due to the async
mainfunction.