Separate CMake option for "build concurrency lib" and "import concurrency implicitly" #37698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency lib" The CMake option `SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCY` was originally meant to imply that we should build the _Concurrency module, which it still does. However, to support minimal stdlib builds, it also became a way to configure the compiler to avoid implicitly importing the _Concurrency module. However, we build configurations of Swift where we want the implicit import but don't want to build the _Concurrency library. Use a new, different option (`SWIFT_IMPLICIT_CONCURRENCY_IMPORT`) for the "implicit import" behavior within the compiler, which defaults to "true", and disable that for minimal stdlib builds. Fixes rdar://78544947. (cherry picked from commit 4c1c8ed)
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
|
Build failed |
|
@swift-ci please test macOS |
airspeedswift
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The CMake option
SWIFT_ENABLE_EXPERIMENTAL_CONCURRENCYwas originallymeant to imply that we should build the
_Concurrencymodule, which it stilldoes. However, to support minimal stdlib builds, it also became a way
to configure the compiler to avoid implicitly importing the
_Concurrencymodule. However, we build configurations of Swift wherewe want the implicit import but don't want to build the
_Concurrencylibrary. Use a new, different option
(
SWIFT_IMPLICIT_CONCURRENCY_IMPORT) for the "implicit import"behavior within the compiler, which defaults to "true", and disable
that for minimal stdlib builds.
Scope: Only affects minimal standard library builds and builds without the concurrency library.
Main Branch PR: #37686
Resolves: rdar://78544947
Risk: Low
Reviewed By: @davezarzycki
Testing: Normal regression testing via CI