[Distributed] synthesize _remote and implement via dynamic #37738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
stdlib/public/stubs/Assert.cpp
Outdated
| @@ -117,3 +117,25 @@ void _swift_stdlib_reportUnimplementedInitializer( | |||
| free(log); | |||
| } | |||
|
|
|||
| void _swift_stdlib_reportMissingDistributedActorTransport( | |||
There was a problem hiding this comment.
TODO move to distributed module
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
ktoso
commented
Jun 2, 2021
|
@swift-ci please smoke test Linux Platform |
ktoso
force-pushed
the
wip-distributed-dynamic-2
branch
2 times, most recently
from
f5a0cd8 to
f6115f4
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-dynamic-2
branch
from
f6115f4 to
99aff07
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-dynamic-2
branch
from
29c3686 to
3dcb0c2
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-distributed-dynamic-2
branch
from
5329f5e to
bb9f2e4
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @DougGregor's redesign idea, where we can use dynamic functions to replace the _remote case for a distributed call.
It seems likely we'd want some
_remoteReplacement(for: hello())to sugar this a bit, then we can require the function benonisolatedas well as hide the existence of_remote_hellocompletely.