[apinotes] Rename NSApplication activateIgnoringOtherApps(_:) to activate(ignoringOtherApps:) #3774
Conversation
|
Let me discuss this change with the AppKit people. |
| @@ -141,3 +141,10 @@ extension NSWindowController { | |||
| self.dismissController(sender) | |||
| } | |||
| } | |||
|
|
|||
| extension NSApplication { | |||
There was a problem hiding this comment.
This part wouldn't be necessary; the compiler generates stubs for the name as imported in Swift 2.
There was a problem hiding this comment.
Oh, ok. Then I wonder why some of the other methods here exist, when they could have just been done with APINotes?
…vate(ignoringOtherApps:)
|
After having discussed the proposed change with the API owners, we will accept the PR. One thing to note though, since changes like this one affect the framework APIs, a proper discussion should be triggered by a radar. So please, file a radar if you (and it's not only you, @jtbandes) think that some APIs can be improved for Swift. Thanks, Jacob for bringing this one up! |
|
@swift-ci Please test and merge |
|
Thank you! For completeness, I've just filed rdar://27556394. |
|
Failures unrelated. |
|
@moiseev This is worth another shot now that CI builds are working. |
|
@swift-ci please smoke test and merge. |
|
Thanks, @CodaFi |
|
I think this failure was related to #3816. |
|
I think so too. Let's try again @swift-ci please smoke test and merge. |
|
@swift-ci smoke test |
|
@swift-ci smoke test linux |
|
@tkremenek Did you mean to start the smoke test? (Just asking b/c you just merged). If not I would like to kill the job. |
|
@gottesmm I started the smoke test for Linux, and realized it was not needed because this does not impact Linux. |
|
@tkremenek Ok. I will kill the job. |
|
@gottesmm thanks. |
|
Thanks all 😊 |
What's in this pull request?
Renaming
activateIgnoringOtherApps(_:)toactivate(ignoringOtherApps:).I'm not sure if changes like this are supposed to go through swift-evolution? It seems like a pretty obvious one to me. cc @moiseev who has worked on the overlay before
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.