[5.5][ConstraintSystem] Simplify relational constraints with the same depe… #37767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndent member type on both sides If relational constraint has the same dependent member type on both sides e.g. `$T1.Element == $T1.Element` allow its simplification, since inference of `$T1` results in dependent member being resolved to the same concrete type. Otherwise constraint system would be left with this constraint in inactive state if `$T1` couldn't be resolved which results in a crash. Resolves: rdar://78623338 (cherry picked from commit 1c3d685)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
DougGregor
approved these changes
Jun 4, 2021
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndent member type on both sides
Cherry-pick of #37699
If relational constraint has the same dependent member type on both
sides e.g.
$T1.Element == $T1.Elementallow its simplification,since inference of
$T1results in dependent member being resolvedto the same concrete type. Otherwise constraint system would be left
with this constraint in inactive state if
$T1couldn't be resolvedwhich results in a crash.
Scope: Invalid expressions with same-type requirements on dependent members e.g.
passing a member reference instead of forming a call to a parameter that has
conformance requirements.
Main Branch PR: [ConstraintSystem] Simplify relational constraints with the same depe… #37699
Resolves: rdar://78623338
Risk: Low
Reviewed By: @hborla
Testing: Regression tests added to the suite
Resolves: rdar://78623338
(cherry picked from commit 1c3d685)