Skip to content

Finish IRGen and reflection for global-actor-qualified and differentiable function types #37769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

Finish and fix IR generation and reflection for global-actor-qualified and differentiable function types, which involves a few steps:

  • Emit a call to swift_getFunctionTypeMetadataGlobalActor when generating metadata for a global-actor-qualified function type
  • Fix a bug with metadata generation for differentiable function types where we generated the wrong IR constant
  • Improve reflection dumping and add tests for global-actor-qualified function types and reflection (it was already implemented correctly)
  • Implement reflection and add tests for differentiable function types

This is the last part of rdar://78269642

@DougGregor
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 3, 2021

Build failed
Swift Test Linux Platform
Git Sha - f3f0b93

@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

@DougGregor DougGregor force-pushed the extended-function-type-reflection branch from 74e282e to a140364 Compare June 4, 2021 14:34
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor merged commit b3cd558 into swiftlang:main Jun 4, 2021
@DougGregor DougGregor deleted the extended-function-type-reflection branch June 4, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants