Skip to content

IRGen: handle static imports in deserialised modules #37775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jun 3, 2021

This showed up when trying to convert swift-package-manager to build
using static linking on Windows. We would not correctly identify the
module as being static due to there being no DeclContext for emission.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Jun 3, 2021

@swift-ci please test Windows platform

This showed up when trying to convert swift-package-manager to build
using static linking on Windows.  We would not correctly identify the
module as being static due to there being no DeclContext for emission.
@compnerd compnerd force-pushed the static-deserialization branch from 302db05 to 1f39610 Compare June 5, 2021 17:08
@compnerd
Copy link
Member Author

compnerd commented Jun 5, 2021

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Jun 5, 2021

CC: @slavapestov

@compnerd
Copy link
Member Author

compnerd commented Jun 5, 2021

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Jun 5, 2021

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2021

Build failed
Swift Test Linux Platform
Git Sha - 1f39610

@compnerd
Copy link
Member Author

compnerd commented Jun 6, 2021

@swift-ci please test Linux platform

@compnerd compnerd merged commit 50fa6cf into swiftlang:main Jun 12, 2021
@compnerd compnerd deleted the static-deserialization branch June 12, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants