StdlibUnittest: repair in-process concurrency test execution #37785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support for running concurrency tests individually with filters invoked the non-concurrent supporting `runOneTest` accidentally. Fix this to us the `runOneTestAsync` allowing the single async test to be run in process again. This is needed for ease of debugging (and in the case of Windows, the only option for debugging).
|
CC: @etcwilde |
|
@swift-ci please test |
etcwilde
approved these changes
Jun 4, 2021
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for running concurrency tests individually with filters
invoked the non-concurrent supporting
runOneTestaccidentally. Fixthis to us the
runOneTestAsyncallowing the single async test to berun in process again. This is needed for ease of debugging (and in the
case of Windows, the only option for debugging).
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.