Skip to content

[5.5-05142021] Fix ClassDecl::isRootDefaultActor to use the maximal resilience expansion #37786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

@aschwaighofer aschwaighofer commented Jun 4, 2021

Otherwise, we fail to emit default actor layout fields and intialization
and deintialization routine calls.

Meaning that actors in resilient libraries are broken.

rdar://78622313

…esilience expansion

Otherwise, we fail to emit default actor layout fields and intialization
and deintialization routine calls.

Meaning that actors in resilient libraries are broken.

rdar://78622313
@aschwaighofer aschwaighofer requested a review from a team as a code owner June 4, 2021 14:53
@aschwaighofer aschwaighofer changed the title [5.5-05142021] Fix ClassDecl::isRootDefaultActor to use the maximal r… [5.5-05142021] Fix ClassDecl::isRootDefaultActor to use the maximal resilience expansion Jun 4, 2021
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer aschwaighofer requested a review from rjmccall June 4, 2021 14:53
@aschwaighofer
Copy link
Contributor Author

@swit-ci nominate

@aschwaighofer
Copy link
Contributor Author

@swift-ci nominate

@aschwaighofer
Copy link
Contributor Author

The change for this in main is in #36878

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airspeedswift airspeedswift merged commit d96fea5 into swiftlang:release/5.5-05142021 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants